Skip to content

fix(chart): global image registry bug in 3.3.3

Placeholder Patrik Votoček requested to merge github/fork/cookielab/image-registry into main

Explanation

This PR fixies bug with was introduced with my previous PR !11482 (merged)

Related issue

Closes #11579 (closed)

What type of PR is this

/kind bug

Proposed Changes

$ helm template ./charts/kyverno | grep image:
                          image:
                              image:
                              image:
                          image:
                              image:
                              image:
          image: "ghcr.io/kyverno/kyvernopre:latest"
          image: "ghcr.io/kyverno/kyverno:latest"
          image: "ghcr.io/kyverno/background-controller:latest"
          image: "kyverno/cleanup-controller:latest"
          image: "kyverno/reports-controller:latest"
      image: busybox:1.35
      image: busybox:1.35
      image: busybox:1.35
      image: busybox:1.35
      image: busybox:1.35
          image: "bitnami/kubectl:1.30.2"
          image: "bitnami/kubectl:1.30.2"
          image: "ghcr.io/kyverno/kyverno-cli:latest"
          image: "bitnami/kubectl:1.30.2"
$ helm template ./charts/kyverno --set global.image.registry=myregistry | grep image:
                          image:
                              image:
                              image:
                          image:
                              image:
                              image:
          image: "myregistry/kyverno/kyvernopre:latest"
          image: "myregistry/kyverno/kyverno:latest"
          image: "myregistry/kyverno/background-controller:latest"
          image: "myregistry/kyverno/cleanup-controller:latest"
          image: "myregistry/kyverno/reports-controller:latest"
      image: busybox:1.35
      image: busybox:1.35
      image: busybox:1.35
      image: busybox:1.35
      image: busybox:1.35
          image: "myregistry/bitnami/kubectl:1.30.2"
          image: "myregistry/bitnami/kubectl:1.30.2"
          image: "myregistry/kyverno/kyverno-cli:latest"
          image: "myregistry/bitnami/kubectl:1.30.2"
$ helm template ./charts/kyverno --set global.image.registry=myregistry --set webhooksCleanup.image.registry="docker.io"
                          image:
                              image:
                              image:
                          image:
                              image:
                              image:
          image: "myregistry/kyverno/kyvernopre:latest"
          image: "myregistry/kyverno/kyverno:latest"
          image: "myregistry/kyverno/background-controller:latest"
          image: "myregistry/kyverno/cleanup-controller:latest"
          image: "myregistry/kyverno/reports-controller:latest"
      image: busybox:1.35
      image: busybox:1.35
      image: busybox:1.35
      image: busybox:1.35
      image: busybox:1.35
          image: "docker.io/bitnami/kubectl:1.30.2"
          image: "myregistry/bitnami/kubectl:1.30.2"
          image: "myregistry/kyverno/kyverno-cli:latest"
          image: "docker.io/bitnami/kubectl:1.30.2"

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.

Merge request reports