Skip to content

fix(devcontainer): add make+gcc and update go version in devcontainer

Placeholder Matt Menzenski requested to merge github/fork/menzenski/add-make-to-devcontainer into main

Explanation

I attended the Kyverno Contribfest today at KubeCon NA in Atlanta. During the presentation the speaker showed a list of GitHub issues tagged with Contribfest - I saw this one and thought it sounded straightforward (and I thought that going through the DEVELOPMENT.md instructions would be a good way to familiarize myself with the project).

This PR makes the following changes:

  • installs make in the devcontainer
  • installs gcc in the devcontainer
  • updates the go version from 1.24.6 to 1.25.3 to match the version in go.mod (go.mod was updated from 1.24 to 1.25 last week in !14255 (merged) - the .devcontainer/Dockerfile go installation command was not updated in that PR)

With the changes in this PR, I am able to build the project and run unit tests in the devcontainer. (The commands make install-tools, make test-unit, and make build-all all failed before these changes and succeeded after).

Related issue

Closes #14247 (closed)

Milestone of this PR

n/a ? (I'm not sure)

Documentation (required for features)

not required

What type of PR is this

/kind bug

(I'm not sure /kind bug is most appropriate here, since it's a devcontainer issue, and not a runtime issue. But the linked issue is type "bug" so I'm choosing that).

Proposed Changes

This PR installs make and gcc, and updates the go version, in the devcontainer, so that the devcontainer may be used to build the project.

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.

Further Comments

Issue #14247 (closed) has a corresponding open PR !14248 (merged) already. That PR makes more substantive changes - it moves away from the .devcontainer/Dockerfile to a third-party devcontainer image with devcontainer features. My PR here is intended to be more minimal, containing only the changes needed to build the project in the devcontainer.

Merge request reports